Closed socoolbreeze closed 1 year ago
Hi @socoolbreeze , thanks for test and screenshot.
As for translations - easiest would be to look directly at https://github.com/tedsalmon/BlueBus/blob/master/firmware/application/lib/locale.c there is an "Edit" button. Try to find / update the localization there. Do not change order, do not add lines, delete lines. (Other than making sure the order for same labels is exactly the same as ENGLISH texts). Than fill in "Propose change" there there, name the branch eg dutch-locale-1.3.0 for Ted or me to test/merge/compile into next release.
What do you mean by "function labels" please?
As for the temperatures, will look at this, I hoped to have it shortened before, but might got lost along the way. One option I personally like, is having one temp in headers - eg. outside temp in the top header beside Bluetooth and phone name, and only the remaining two in the line in Dashboard. Would that be OK? With the right part of the screen, actually, it is not available always, so that may not be viable solution.
Hi @socoolbreeze , thanks for test and screenshot.
As for translations - easiest would be to look directly at https://github.com/tedsalmon/BlueBus/blob/master/firmware/application/lib/locale.c there is an "Edit" button. Try to find / update the localization there. Do not change order, do not add lines, delete lines. (Other than making sure the order for same labels is exactly the same as ENGLISH texts). Than fill in "Propose change" there there, name the branch eg dutch-locale-1.3.0 for Ted or me to test/merge/compile into next release.
What do you mean by "function labels" please?
As for the temperatures, will look at this, I hoped to have it shortened before, but might got lost along the way. One option I personally like, is having one temp in headers - eg. outside temp in the top header beside Bluetooth and phone name, and only the remaining two in the line in Dashboard. Would that be OK? With the right part of the screen, actually, it is not available always, so that may not be viable solution.
![]()
![]()
Thanks for the reply. I just updated the language. And wil do in future release like this. Works great. The function labels I meant like. Every label function like, dashboard or comfort settings where on different places. Probably because of an extra line of code or something. Hope now is the same order and the same amount it will show everything on the right place.
As for the mgmt I hope we can turn the screen on when standing still with car for lights or parking or wondering what song it is. Thanks for the help and temperature fix. For me I like it al in one place. But actually you can make it how you want it. I don't have the skill to code like I want it ;)
Thanks. The shifted labels have been fixed.
Have you saved / proposed your changes in the Localization file? Cannot see it.
https://github.com/tedsalmon/BlueBus/compare/master...socoolbreeze:BlueBus:patch-1
This is where I can see the changes. I'm very new at this. If I have to redo it please let me know.
greetz Ben
Op di 18 okt. 2022 om 16:32 schreef Ivan Debnar @.***>:
Hi @socoolbreeze https://github.com/socoolbreeze , thanks for test and screenshot.
As for translations - easiest would be to look directly at https://github.com/tedsalmon/BlueBus/blob/master/firmware/application/lib/locale.c there is an "Edit" button. Try to find / update the localization there. Do not change order, do not add lines, delete lines. (Other than making sure the order for same labels is exactly the same as ENGLISH texts). Than fill in "Propose change" there there, name the branch eg dutch-locale-1.3.0 for Ted or me to test/merge/compile into next release.
What do you mean by "function labels" please?
As for the temperatures, will look at this, I hoped to have it shortened before, but might got lost along the way. One option I personally like, is having one temp in headers - eg. outside temp in the top header beside Bluetooth and phone name, and only the remaining two in the line in Dashboard. Would that be OK? With the right part of the screen, actually, it is not available always, so that may not be viable solution.
— Reply to this email directly, view it on GitHub https://github.com/tedsalmon/BlueBus/issues/125#issuecomment-1282493253, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARVWKCFHLOFX2GRUMWTNXULWD2YGJANCNFSM6AAAAAARFHE6WQ . You are receiving this because you were mentioned.Message ID: @.***>
Amazing! Thanks, I merged it into fix/1.3.1 branch, so it will be included in next release. Or if you want to try, I can send you a .hex file with the updates.
Ow thanks yeah that would be great if you can shoot me a hex file of the 1.3.1! many thanks
gr Ben
Op ma 31 okt. 2022 om 23:39 schreef Ivan Debnar @.***>:
Amazing! Thanks, I merged it into fix/1.3.1 branch, so it will be included in next release. Or if you want to try, I can send you a .hex file with the updates.
— Reply to this email directly, view it on GitHub https://github.com/tedsalmon/BlueBus/issues/125#issuecomment-1297776859, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARVWKCGC5XL5CPNVSGYIMOTWGBDATANCNFSM6AAAAAARFHE6WQ . You are receiving this because you were mentioned.Message ID: @.***>
Send me an email - address in my profile.
Hi Ivan,
It works great! Everything works with translation. Time sync worked, because I had it stil on summertime for a few weeks and it changed. Als the voice assistant prompt worked.
Only thing I noticed was that the old OBC temp order was sometimes (after start, first 'boot') visible. So it is probably still somewhere in the code.
Thanks!!
Op di 1 nov. 2022 om 11:36 schreef Ivan Debnar @.***>:
Send me an email - address in my profile.
— Reply to this email directly, view it on GitHub https://github.com/tedsalmon/BlueBus/issues/125#issuecomment-1298333048, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARVWKCFYT256DWWXZGPXTW3WGDXEJANCNFSM6AAAAAARFHE6WQ . You are receiving this because you were mentioned.Message ID: @.***>
Glad to hear. For the "temp order" - I am sure the order is never changed, and I have not modified it. What could be happening is that on "cold" start, the OIL temperature had not been yet reported by the engine management, so BB knows only about the 2 other temperatures ( like with common E46 with no oil temp at all ), and thus displays "Temp: ..." line. When the oil temp comes, it will change to shorter format, so all three temps fit on display. Is this what you observed?
Hi It is sometimes on startup indeed. So I thought if you change the order is wil do that also on startup. After one minute it stands in the new order.
greetz Ben
Op ma 7 nov. 2022 om 12:06 schreef Ivan Debnar @.***>:
Glad to hear. For the "temp order" - I am sure the order is never changed, and I have not modified it. What could be happening is that on "cold" start, the OIL temperature had not been yet reported by the engine management, so BB knows only about the 2 other temperatures ( like with common E46 with no oil temp at all ), and thus displays "Temp: ..." line. When the oil temp comes, it will change to shorter format, so all three temps fit on display. Is this what you observed?
— Reply to this email directly, view it on GitHub https://github.com/tedsalmon/BlueBus/issues/125#issuecomment-1305444789, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARVWKCCYEFY4I7CFSXNKOCTWHDPDTANCNFSM6AAAAAARFHE6WQ . You are receiving this because you were mentioned.Message ID: @.***> [image: IMG_9398.JPEG][image: IMG_9399.JPEG]
What a nice release. Looks very stable and nice new features. Love it.
-Length with DASH OBC temps is still to long for my device I think. The right temp has a+ symbol at the end without any numbers with value Maybe naming it from Temp ℃ to just ℃ gives a clean and same result. O:91 C:80 A:10 ℃ or: ℃ O:91 C:80 A:10 ℃ i like te arrange it from low to high: TEMP: A:10 C: 80 O:91 ℃
or if possible on the right side of the screen?! from top every line with info Ambient: Coolant: Oil:
-BMBT ON When activated I cannot turn the screen on at any time.
Maybe possible to do with the standard button?
-Translation updates (now and future release) With dutch translation the new features aren't translated. Where and how can I update it, for now, and pre-release new features? Also the functions labels are in the wrong place so probably a mixup within upgrading from old translation to new with new to translate rules.