tedsalmon / BlueBus

A Bluetooth module for vehicles equipped with I-Bus
Other
169 stars 41 forks source link

Unlock whole E46 #87

Closed nabucho closed 2 years ago

nabucho commented 3 years ago

Unlock the gas tank and trunk along with the doors on E46 and Z4 Fixes #56

Maybe there are people that want trunk and gas tank locked, but this brings it on par with newer BMWs without the need for additional config setting.

tedsalmon commented 3 years ago

@nabucho

Thanks! Let me mull this one over -- not all ZKEs are coded to unlock the High + Low side doors with one press of the central lock button -- neither of mine were seemingly from the factory, so that would actually create a regression as it currently unlocks all doors but not the hatch window, hatch or trunk.

Thanks again! -Ted

nabucho commented 3 years ago

hmm, yeah, I can imagine different defaults for US and EU markets in many configurations. Happy to provide any readings, settings from my EU/GB E46 convertible to compare with yours so we can make a proper identification and unlock calls. Also, asking more BlueBus users about their cars / preferences can guide us, given there can be so many different confugurations to cover. This worked for me, using the codes you advised for people in #56 - so for my situation is perfect. But we should fine the most compatible solution.

piersholt commented 3 years ago

@nabucho I'd recommend accepting @tedsalmon's invitation to the BlueBus slack. There's multiple generations of ZKE, and they vary vastly in design. A command that works on one vehicle might fire the ejector seat on another 😄 . A quick sense check on slack could ensure the best use of your time.

tedsalmon commented 2 years ago

I'm closing this as @piersholt is refactoring the ZKE code.