search

tedsmith / quickhash

Graphical cross platform data hashing tool for Linux, Windows and Mac
http://www.quickhash-gui.org
GNU General Public License v2.0
368 stars 37 forks source link

Linux: build with Makefile, fix taskbar icon, use udevadm not /sbin/u… #73

Closed darealshinji closed 3 years ago

darealshinji commented 4 years ago

…devadm

tedsmith commented 4 years ago

You are right that the git code checkout didn't fully compile ebcause of a missing pas and a missing lfm. I've now added those two, too. Having added them, I able to compile, launch (as sudo) and hash a disk.

On my system, udevadm is in /sbin/udevadm. If we change it to "udevadm...", on my system, it says it cant find it.

tedsmith commented 4 years ago

@darealshinji - with the latest commit to master, are you able to confirm if building is now possible? It seems to be on my system now.

darealshinji commented 4 years ago

On my system, udevadm is in /sbin/udevadm. If we change it to "udevadm...", on my system, it says it cant find it.

I guess /sbin isn't in PATH by default then, otherwise it would work I guess. On some Ubuntu versions it's only in /bin/udevadm so using an absolute path is not realiable on all Linux distros.

Edit: quickhash_linux.lpi needs to be added too. And you should remove the compiled QuickHash binary from the repo.

tedsmith commented 3 years ago

I've deleted the binary which you correctly identified had sneaked in there.

I've re-added the quickhash_linux.lpi file that Git is telling me it is now conflicting with this pull request, so I'm not sure whether that is resolvable or not. I went to "resolve conflicts" but there doesn't seem to be a button to accept or reject. All I changed was the (c) year and the title value. I'm not sure why we have that file though? Is it needed for the makefile? It suggests we need a different lpi for Linux but I always just use the main one for all 3 platforms.

darealshinji commented 3 years ago

Conflicts should now be resolved. Yes, I think the separate lpi was needed to be able to build with Makefile out of the box.