ctrl+c from within an active ssm connection kills the ecsgo session

tedsmitt / ecsgo

Provides an interactive prompt to connect to ECS Containers using the ECS ExecuteCommand API.

Apache License 2.0

81 stars 13 forks source link

ctrl+c from within an active ssm connection kills the ecsgo session #29

Closed userhas404d closed 1 year ago

userhas404d commented 1 year ago

First off, thank you for this tool!

Seeing this behavior on the latest version, details are pretty straightforward and easily reproducible but happy to provide more on request.

tedsmitt commented 1 year ago

Hey @userhas404d I've fixed this in https://github.com/tedsmitt/ecsgo/releases/tag/v0.4.5-beta.2 - can you check it out and feedback?

userhas404d commented 1 year ago

finally had a chance to test this today and was able to confirm it works. Thank you!

If you want a separate issue for this I can create one (not a huge deal from my perspective) but I did notice that the beta release does not provide version information:

❯ ecsgo-beta --version
ecsgo version Version: unset, Commit: unset, Built date: unset, Built by: unset

tedsmitt commented 1 year ago

Hey @userhas404d thank you so much for taking the time to test! Much appreciated.

Also great spot! I raised https://github.com/tedsmitt/ecsgo/issues/35 and have pushed a fix, so this will be resolved when I create the new release.