search

tedsmitt / ecsgo

Provides an interactive prompt to connect to ECS Containers using the ECS ExecuteCommand API.
Apache License 2.0
82 stars 13 forks source link

Tool is ignoring HTTPS_PROXY/HTTP_PROXY #47

Open gowens-leolabs opened 3 months ago

gowens-leolabs commented 3 months ago

Our company uses a corporate proxy for AWS access and for various applications if we use HTTPS_PROXY/HTTP_PROXY the application would simply understand that communication needs to go out that path but this mechanism doesn't seem to work with ecsgo. As far as I can tell, it completely ignores the proxy settings and the application doesn't have any kind of proxy switch so this tool is completely unusable for us.

tedsmitt commented 1 month ago

Hey @gowens-leolabs,

According to the AWS SDK v1 docs, the HTTP_PROXY env var is supported and should be taken into consideration. However, I have noticed that it doesn't list HTTPS_PROXY in these docs, whereas in the v2 docs, it does.

Regardless, I'm not really able to reproduce this (at least not using something like Squid Proxy locally), see below

ecsgo-proxy

I am looking at upgrading to the v2 SDK in the coming weeks, not sure if this will have an impact or not.

tedsmitt commented 1 month ago

@gowens-leolabs ecsgo now uses the Go AWS SDK v2, can you let me know if it is handling the environment variables any differently?