TaylorF2 and IMRPhenomD_NRTidalv2

[ThibeauWouters]

This PR adds the TaylorF2 and IMRPhenomD_NRTidalv2 waveforms in ripple.

As I already mentioned, it would be good to discuss whether the current approach with the utils_tidal.py file in the waveforms directory is a good idea for future work that will integrate the NRTidalv2 corrections on top of other BBH waveforms.

I am happy to discuss further and make changes accordingly!

[tedwards2412]

This all looks great @ThibeauWouters! Couple of things to look at before merging:

• There is quite a lot of extra stuff in the PR, like the csv files that contain matches. In general I'd like to keep the repo lightweight and remove this kind of stuff. The test scripts are good though, so let's keep them. I also saw a .idea file which I'm not sure what its doing so would prefer to remove unless its necessary.
• I think having the utils_tidal.py file makes sense, I'd just like to have a better naming scheme for the file. We are likely to bring in non-IMRPhenom waveforms at some point soon, so it would be good to have the file naming be specific and easy to navigate. How about utils_tidal.py becomes IMRPhenom_tidal_utils.py?

[ThibeauWouters]

Hi @tedwards2412,

Thank you so much for the feedback! I totally agree with the .csv files, I think I was so used to them being there for testing the waveform that I just forgot to remove them basically.

I have renamed the tidal utils file, but the TaylorF2 waveform also uses one function from that file, which can be a bit confusing at this point. Depending on which waveforms will be added in the future, there might be some tidal utilities shared between all tidal waveforms, and some utilities shared between IMRPhenom waveforms with tidal effects, so perhaps we might have to change this again. I think apart from that, the renaming makes sense indeed.

Cheers

[tedwards2412]

This looks great, thanks!