tedwards2412 / ripple

Differentiable Gravitational Waveforms with JAX
51 stars 14 forks source link

TaylorF2 reference #30

Closed Felipe-4 closed 1 day ago

Felipe-4 commented 2 days ago

I am new to GWs so that's probably why I am not finding it, but what is the reference for TaylorF2? In the LALsuite they reference section III F of this paper which doesn't look like the function implemented here, for one thing the tidal parameters are missing in the formulas of this section.

tedwards2412 commented 2 days ago

Hi @Felipe-4, unfortunately TaylorF2 has been developed over a number of publications and different versions contain terms up to different PN orders. The paper you linked is a good starting point, but won't contain all the higher order terms (for example the tidal parameters). This notebook https://github.com/tedwards2412/ripple/blob/main/notebooks/check_TaylorF2.ipynb demonstrates that we match with the lalsuite implementation though. Does this help?

Felipe-4 commented 1 day ago

Ok, Thank you.