tee-ar-ex / trx-python

Python implementation of the TRX file format
https://tee-ar-ex.github.io/trx-python/
BSD 2-Clause "Simplified" License
20 stars 16 forks source link

Data validation #35

Open Lestropie opened 2 years ago

Lestropie commented 2 years ago

Thought came to mind chatting with @frheault regarding #33.

Particularly with fast implementations that can omit certain bounds checking, malformed data can result in very unusual bugs.

What would help here, similarly to MRtrix3/mrtrix3#2418, would be to have a dedicated command that performs a more exhaustive check of the raw data. So e.g. make sure that streamlines don't overlap, don't exceed the bound reported in the header, that sort of thing. Streamlines with zero or one vertex should be counted and reported; such things should actually be legal and are highly useful in some circumstances, but in other circumstances they may be indicative of a problem.

arokem commented 4 months ago

Was this resolved by #37 ?