Closed frheault closed 1 year ago
@anibalsolon What do you think?
@frheault looks good- I'll follow the implementation on C++
When you get a chance, could you please rebase after the #37 merge?
LGTM. Still WIP?
It would need to be tested on a Mac, I am not sure how it behaves. I will ask Maxime D. to borrow one next week
Oh - I have a mac. Let me run the test suite and let you know.
Tests pass on a mac. Good to go?
Actually, could you please rebase on your end first? I tried to do this locally and see there are a couple of conflicts that would need resolution.
This PR is related to Issue #40
This requires PR #37 to be merged first, I needed the new module trx.io to exist to test some things.
Simply replaces all calls to
tempfile.TemporaryDirectory
by a new function below:3 options:
I will add a check if the folder does not exist. But should I create it myself?