search

tee-ar-ex / trx-python

Python implementation of the TRX file format
https://tee-ar-ex.github.io/trx-python/
BSD 2-Clause "Simplified" License
20 stars 16 forks source link

setuptools_scm shouldn't be in the runtime dependency list #73

Open yurivict opened 7 months ago

yurivict commented 7 months ago

here

arokem commented 7 months ago

Where should it go instead?

yurivict commented 7 months ago

It should be a setup or configure dependency.

arokem commented 6 months ago

That doesn't seem to work, see #75

musicinmybrain commented 3 months ago

The logs from the CI run on #75 have been cleaned up, so I can’t see what was going wrong.

In any case, I agree that setuptools_scm doesn’t need to be a runtime (“installation”) dependency because it isn’t imported after build.

Note that PEP517 builds should be getting the setup dependency from

https://github.com/tee-ar-ex/trx-python/blob/81c3efde71359f6fade75f53864fc2174f5f327a/pyproject.toml#L2