search

teejee2008 / timeshift

System restore tool for Linux. Creates filesystem snapshots using rsync+hardlinks, or BTRFS snapshots. Supports scheduled snapshots, multiple backup levels, and exclude filters. Snapshots can be restored while system is running or from Live CD/USB.
GNU Lesser General Public License v3.0
4.69k stars 282 forks source link

Unwanted timeshift-hourly crontab file #239

Open anonymous352 opened 6 years ago

anonymous352 commented 6 years ago

I've noticed that Timeshift adds a crontab file in /etc/cron.d named timeshift-hourly if one does not exist, even if Timeshift runs with or without error. I have only configured Timeshift for running at '@reboot' time and no other times. As a result I have to keep removing this unwanted timeshift-hourly file as I do not want it to run hourly at all. Any idea if this is a bug or intended behaviour ?

azalea4va commented 6 years ago

Any idea if this is a bug or intended behaviour ?

I submit this is in fact a bug, although it may have been the original intended behavior. Design bugs happen, just as code bugs do.

The problem is actually worse than what you describe. Even if /etc/cron.d/timeshift-hourly exists, if it has been modified, it gets overwritten with what the original looked like. This behavior is inconsistent with application norms for the design of how applications use configuration files. By overwriting the configuration file, the behavior is not really configuarable, it is essentially hard-coded.

victorbrca commented 4 years ago

Another comment on this is that if you try to configure alerts with something like halthchecks.io, the cron file gets overwritten after the first run.