search

teejee2008 / timeshift

System restore tool for Linux. Creates filesystem snapshots using rsync+hardlinks, or BTRFS snapshots. Supports scheduled snapshots, multiple backup levels, and exclude filters. Snapshots can be restored while system is running or from Live CD/USB.
GNU Lesser General Public License v3.0
4.68k stars 282 forks source link

Allows incomplete restores #637

Open Larrik opened 4 years ago

Larrik commented 4 years ago

Note: This application is provided "as-is" without support or warranty. Due to lack of time, I check this tracker once every few months. If you need help with an issue, consider posting the issue on Linux Mint forums where there are more people to help you out.

Describe the bug As a first time user of Timeshift during an (abandoned) upgrade from Linux Mint 19.3 to 20.1, I ran into an interesting bug. First, I made 2 backups, as prescribed at https://linuxmint-user-guide.readthedocs.io/en/latest/upgrade-to-mint-20.html After I discovered I'm not at all ready for Ubuntu 20.04 as a base, I attempted to restore back to the first backup.

When clicking the restore button, it started reading the log files, but the Next button was enable. I clicked the Next button WAY too early, and ended up with a very incompletely system restore.

Once I realized (hours later) what happened, I did it correctly and was very impressed by how awesome Timeshift is. It just let me shoot myself in the foot a little too easily.

To Reproduce Steps to reproduce the behavior:

  1. Have a backup (in this case on a prior release)
  2. Click on Restore
  3. Click on Next without waiting for "read log files" step to complete.

Expected behavior Can't click "Next" before Timeshift is ready

Screenshots If applicable, add screenshots to help explain your problem.

System:

sgornick commented 3 years ago

I too did this on my first attempt to restore a snapshot using Timeshift.

I saw the Next button so I assumed the Parsing log files step could be skipped. I then, during Preparing, had the ability to again click Next (prematurely) as well, and got to the end of my restore of a 12GB snapshot within seconds, so I realized I had done that wrong.

Those instances of a Next button should probably be a Cancel button instead, until the point in time the process is complete, at which time Next button leads to the appropriate next step.