search

teejee2008 / timeshift

System restore tool for Linux. Creates filesystem snapshots using rsync+hardlinks, or BTRFS snapshots. Supports scheduled snapshots, multiple backup levels, and exclude filters. Snapshots can be restored while system is running or from Live CD/USB.
GNU Lesser General Public License v3.0
4.66k stars 280 forks source link

incompatibility with latest rsync 3.2.4 #891

Closed clusterx closed 2 years ago

clusterx commented 2 years ago

Details: https://bbs.archlinux.org/viewtopic.php?pid=2032506#p2032506

temporary solution - downgrade rsync to version 3.2.3-4 pacman -U https://archive.archlinux.org/packages/r/rsync/rsync-3.2.3-4-x86_64.pkg.tar.zst

manfred3000 commented 2 years ago

I haven't encountered any issues so far running timeshift on a fully updated arch system. What error messages does rsync give? Have you reported the issue there, as well?

MightyTree commented 2 years ago

Got the same issue, there is barely anything besides "E: rsync returned an error", even with --debug and --verbose flags, as mentioned in the archlinux forum post. Downgrading rsync works for now. And timeshift deletes the fill rsync-log along with the folder once it finishes. Any idea how to retain that?

Falav commented 2 years ago

Thanks @clusterx, I was struggling finding a solution. Downgrading rsync indeed made Timeshift work again. I use Manjaro, on Unstable branch, so closest to Arch packages versions.

begin-theadventure commented 2 years ago

Woah, I tried to do so many things and wondered why it didn't work.. sudo downgrade rsync, add rsync to IgnorePkg? [y/N] y and rebooted just in case. Thanks.

moritz-john commented 2 years ago

Downgrading rsync to version 3.2.3-4 also fixed the issue for me. Now I am able to create and see snapshots in the timeshift GUI again.

CodeCubeNeo commented 2 years ago

Well someone needs to figure out why it's incompatible with the latest rsync

miicat commented 2 years ago

Timeshift GUI didn't work, but it worked on terminal with rsync 3.2.4-1
Downgrading to 3.2.3-4 fixed the GUI

JoonasPitk commented 2 years ago

For me, the GUI works and creates a snapshot folder, but it is not listed. CLI is also borked, where the folder I just made with the GUI isn't recognised. Also, if I try to create a snapshot through terminal, it fails and deletes my manual snapshot as well...

The manual snapshots are missing the info.json files.

Reno-Sifana commented 2 years ago

Thanks @clusterx, I was struggling finding a solution. Downgrading rsync indeed made Timeshift work again. I use Manjaro, on Unstable branch, so closest to Arch packages versions.

I also experienced it a few days ago. Timeshift suddenly creates a snapshot every hour. But I see in timeshift GUI No snapshot list as usual. Checking with the "systemctl status cronie" command shows that it failed to create a new snapshot. Finally I tried uninstalling timeshift. The intention was to reclaim free space in the /run/timeshift/ folder, I tried the command sudo rm -rf /run/timeshift/, but it showed an error device is busy and my linux couldn't be used. I finally immediately reinstalled my linux

Reno-Sifana commented 2 years ago

Downgrading rsync to version 3.2.3-4 also fixed the issue for me. Now I am able to create and see snapshots in the timeshift GUI again.

I tried in terminal and GUI Finally it works. Screenshot_2022-05-02_08-23-22 Screenshot_2022-05-02_08-16-38 But in the update notification there is Rsync 3.2.4.1

Reno-Sifana commented 2 years ago

Details: https://bbs.archlinux.org/viewtopic.php?pid=2032506#p2032506

temporary solution - downgrade rsync to version 3.2.3-4 pacman -U https://archive.archlinux.org/packages/r/rsync/rsync-3.2.3-4-x86_64.pkg.tar.zst

Why don't you try reporting the bug here https://github.com/WayneD/rsync/issues?q=is%3Aissue

sarmong commented 2 years ago

@Reno-Sifana this version of rsync works fine on it's own, but not with Timeshift

Reno-Sifana commented 2 years ago

@Reno-Sifana this version of rsync works fine on it's own, but not with Timeshift

Okay. I understand what you're saying. Thank you

jonathonf commented 2 years ago

Has anyone actually tried rebuilding the package against the latest rsync, as with any other AUR package that "breaks" after an update?

sarmong commented 2 years ago

@jonathonf yes. Didn't fix it

clusterx commented 2 years ago

the new rsync version was released due to security critical vulnerabilities so downgrading is not a permanent solution!

Rsync version 3.2.4 has been released. Another typical release with both bug fixes and some enhancements. It also contains a security fix for the bundled zlib 1.2.8, which may or may not be used in your particular build configuration. https://rsync.samba.org/

JoonasPitk commented 2 years ago

My downgraded rsync does work with the zlib 1.2.12. Of course situation shouldn't be permanent, unless Timeshift starts shipping its own fork of rsync.

clusterx commented 2 years ago

My downgraded rsync does work with the zlib 1.2.12. Of course situation shouldn't be permanent, unless Timeshift starts shipping its own fork of rsync.

basically means, it's not compatible with the official rsysnc version

MartinX3 commented 2 years ago

20 days without an reaction. Time to search for an alternative solution.

What's about borg backup? https://github.com/borgbackup/borg It also has a GUI app if you dislike the terminal.

It's more used than timeshift and well maintained.

Reno-Sifana commented 2 years ago

Hmm. I'm curious, Why in some Linux distributions Timeshift is pre-installed. For example in Linux Mint.

MartinX3 commented 2 years ago

Hmm. I'm curious, Why in some Linux distributions Timeshift is pre-installed. For example in Linux Mint.

It's an old decision in the past. Maybe it was a good choice then. And changing standard stuff in a distribution is nothing which happens fast.

Also the newest rsync version in ubuntu is 3.2.3 in Ubuntu kinetic Linux Mint 20.3 uses Ubuntu 20.04 with rsync 3.1.3 and Ubuntu 22.04 uses rsync 3.2.3.

They will throw Timeshift away after they update rsync.

Moonbase59 commented 2 years ago

Same bug here: Manjaro stable 21.2.6, rsync 3.2.4-1, Timeshift 21.09.1-3.

This issue should be addressed with high priority, since many users, and especially newbies, have learned and been trained to use Timeshift for safe backups.

Nydoehar commented 2 years ago

20 days without an reaction. Time to search for an alternative solution.

What's about borg backup? https://github.com/borgbackup/borg It also has a GUI app if you dislike the terminal.

It's more used than timeshift and well maintained.

I was thinking the same. Is it borg as easy to use as Timeshift?

MartinX3 commented 2 years ago

I was thinking the same. Is it borg as easy to use as Timeshift?

In my opinion yes

Nydoehar commented 2 years ago

I was thinking the same. Is it borg as easy to use as Timeshift?

In my opinion yes

* https://borgbackup.readthedocs.io/en/stable/quickstart.html

* https://wiki.ubuntuusers.de/BorgBackup/

* GUI's

  * https://vorta.borgbase.com/
  * https://gitlab.gnome.org/World/pika-backup

Thank you!!! Gonna check it out. I started to use Timeshift a little more than one month ago, and it already fail me...

moritz-john commented 2 years ago

I was thinking the same. Is it borg as easy to use as Timeshift?

I'd argue that the two tools were build for completely different purposes:

I use Timeshift to try out new settings, software or configs and if it does not work or something breaks I can easily go back to a working system version.

On the other hand I'd use something like Borg to backup important files in case my HDD breaks.

From the Timeshift description: Timeshift [...] is designed to protect only system files and settings. User files such as documents, pictures and music are excluded.

Nydoehar commented 2 years ago

I was thinking the same. Is it borg as easy to use as Timeshift?

I'd argue that the two tools were build for completely different purposes:

I use Timeshift to try out new settings, software or configs and if it does not work or something breaks I can easily go back to a working system version.

On the other hand I'd use something like Borg to backup important files in case my HDD breaks.

From the Timeshift description: Timeshift [...] is designed to protect only system files and settings. User files such as documents, pictures and music are excluded.

I see. I liked Timeshift a lot for the two weeks it worked for me, but since it not working properly for now I gonna check out alternatives.

MartinX3 commented 2 years ago

From the Timeshift description: Timeshift [...] is designed to protect only system files and settings. User files such as documents, pictures and music are excluded.

Timeshift does snapshots and also backups the user.

The files are in the backups and the backups are either btrfs or hardlink snapshots via rsync. (See ext4 hardlinks).

Borg backup also backup files and "snapshot" them like Timeshift, but doesn't depend on rsync. Plus it compresses and encrypt you backups and client network network architecture, if you don't want to run it on the same computer.

cziss commented 2 years ago

Hi, same problem here, on both computers with Manjaro. Downgrade rsync solution is not nice.

Nydoehar commented 2 years ago

Hi, same problem here, on both computers with Manjaro. Downgrade rsync solution is not nice.

Yes, it isn't. Check out Borg Backup, it seems a good alternative.

cziss commented 2 years ago

Thank you for the advice. But I'm not really sure if Borg Backup is really alternative. I just want to "save" my system and when something goes wrong to easily restore it. Well, I think that I'll wait some time if it'll be solved.

ratcashdev commented 2 years ago

PR submitted.

yochananmarqos commented 2 years ago

@ratcashdev Is it really that simple? No wonder I wasn't affected as I'm already using UTF-8.

I've implemented your PR with 21.09.1-4 in the Manjaro community repo and the AUR.

HowWof commented 2 years ago

It is possible to have timeshift version in flatpack because then theoretically we could still keep obsolete versions to run timeshift and it would not be bad because dependencies would not affect the system and they would be in a container?

ratcashdev commented 2 years ago

@ratcashdev Is it really that simple? No wonder I wasn't affected as I'm already using UTF-8.

I've implemented your PR with 21.09.1-4 in the Manjaro community repo and the AUR.

Package updated on my laptop and working nicely. Thanks for this quick repo update on Manjaro (my favorite OS)! Much obliged!

cziss commented 2 years ago

thank you, it works fine now :+1:

MartinX3 commented 2 years ago

@clusterx the PR is not merged. So the issue is still existing for everyone without this AUR package but with rsync 3.2.4.

dandreossi commented 2 years ago

A workaround could be run env LC_ALL=C.UTF-8 timeshift or env LC_ALL=C.UTF-8 timeshift-gtk (if someone need GUI)

marko19914 commented 2 years ago

Hello! Same issue on Fedora 36. Downgrade and versionlocking solved the issue for now.

emereld commented 1 year ago

Yes, same issue with Fedora 36. Workaround as described above fixes the issue for now:

# add rsync version lock
sudo dnf install rsync.x86_64-3.2.3-14.fc36
sudo dnf install python3-dnf-plugin-versionlock-4.2.1-1.fc36.noarch
sudo dnf versionlock add rsync-3.2.3-14.fc36.x86_64

# remove rsync version lock
sudo dnf versionlock delete rsync-3.2.3-14.fc36.x86_64
JoonasPitk commented 1 year ago

Fedora hasn't moved to the maintained fork? https://github.com/linuxmint/timeshift

emereld commented 1 year ago

Seems like Fedora/RedHat has not switched yet, yes

21.09.x is their last version. https://koji.fedoraproject.org/koji/packageinfo?packageID=26246