search

teekamsuthar / Mutify

An android app built with java to mute Spotify ads.
MIT License
82 stars 17 forks source link

Help translate Mutify. #3

Open teekamsuthar opened 3 years ago

teekamsuthar commented 3 years ago

Although, translations to any language are welcomed. Here are the translations required as per user-base ordered by priority -

Recommend tool for translation - Android Studio with translation helper plugin.

gupta-shrinath commented 2 years ago

Hi, Teekam Congratulations on building this helpful application. I would like to work on this. I have translated it to German(Germany) and Spanish (Spain) using google translate and working on Vietnamese and French. The dialog_positive_btn and open_spotifystring key have the same value Open Spotify should I change code to use only open_spotify?

gupta-shrinath commented 2 years ago

The source code in the master branch seems to be of the older version of the application. Maybe you have continued the development of the application in private. If the current version of the application doesn't support the languages mentioned in the PR you could merge it because it won't have any major breaking changes.

teekamsuthar commented 2 years ago

Thanks for helping out with the current translations in Mutify @gupta-shrinath, I will be pushing out a new commit with updated strings soon, so please let me know if you will be able to help with translation of those as well. :)

teekamsuthar commented 2 years ago

The dialog_positive_btn and open_spotifystring key have the same value Open Spotify should I change code to use only open_spotify?

Yes, please keep all the extra duplicate values, even if they're same. The id's are different so that these can be identified easily in code, also it helps with code readability. Thanks :)

gupta-shrinath commented 2 years ago

The dialog_positive_btn and open_spotifystring key have the same value Open Spotify should I change code to use only open_spotify?

Yes, please keep all the extra duplicate values, even if they're same. The id's are different so that these can be identified easily in code, also it helps with code readability. Thanks :)

Make sense. I thought of this and to be on the safer side created a new commit I'll just have to revert the commit in the PR.

Thanks for helping out with the current translations in Mutify @gupta-shrinath, I will be pushing out a new commit with updated strings soon, so please let me know if you will be able to help with translation of those as well. :)

Sure.

gupta-shrinath commented 2 years ago

Hi, @teekamsuthar I have reverted the commit which removes the key dialog_positive_btn.