teel / apostasis

Automatically exported from code.google.com/p/apostasis
0 stars 0 forks source link

Code review request #26

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Purpose of code changes on this branch:
Added heroism/bloodlust display

When reviewing my code changes, please focus on:
Check heroisms are shown correctly (blue shaded regions on the plot). In 
particular, it's untested 
with bloodlust - the spell ID might be incorrect.

After the review, I'll merge this branch into:
/trunk
(this was the last thing I wanted to do before merging the plot tree into the 
trunk)

Original issue reported on code.google.com by eddedmondson on 10 Feb 2010 at 9:45

GoogleCodeExporter commented 8 years ago
I should add that if you're wondering what exactly needs testing, I've been 
developing in a separate branch 
plotting capabilities. You need to add '-plot' as an option to the parse, and 
have the .js files from 
http://code.google.com/p/flot/ added to your extras directory.

Original comment by eddedmondson on 10 Feb 2010 at 10:04

GoogleCodeExporter commented 8 years ago
So far it has nailed it everytime compared against EHFS for bloodlust.  I have 
an
alternative version of the -plot code in my library (same php code just 
extracted the
javascript into sws-flot.fs and objectified it to improve speed and allow for 
reuse). 

Original comment by mouring%...@gtempaccount.com on 24 Mar 2010 at 6:15

GoogleCodeExporter commented 8 years ago

Original comment by eddedmondson on 13 May 2010 at 11:00