'end friendly' only is checked on damage events, can fail on fights like Algalon

[GoogleCodeExporter]

Algalon ends friendly, but if that setting is used with stasiscl for that
boss, it can fail to detect it, probably because of the unusually long
delay between Algalon going unattackable and going friendly allowing for
dots to expire.

For example, in the log here (6 Algalon 10 man attempts, the 6th being a
victory):
http://www.variadic.org/faal/WoWCombatLog-20090620-Faal.txt.gz

The last damage event of any kind to Algalon was:
6/20 22:31:30.263 
SPELL_PERIODIC_DAMAGE,0x0600000000769C0A,"Komskies",0x512,0xF13000806702170E,"Al
galon
the Observer",0xa28,49800,"Rip",0x1,2259,0,1,0,0,0,nil,nil,nil

But the first 'friendly' flagged event came after it on an aura removal:
6/20 22:31:31.075 
SPELL_AURA_REMOVED,0x0600000000769C0A,"Komskies",0x512,0xF13000806702170E,"Algal
on
the Observer",0xa18,48566,"Mangle (Cat)",0x1,DEBUFF

The problem is that the function that checks end friendly ('process') isn't
passed the SPELL_AURA_REMOVED events so it never sees Algalon go friendly
in that log.

Original issue reported on code.google.com by swbro...@gmail.com on 28 Jun 2009 at 6:41

[GoogleCodeExporter]

The attached patch appears to fix it for me, although I've not tested it much.  
It
basically adds the same kind of check as is done in 'process' for damage events 
to
the timeout checking path to check aura events, which is split into two and the 
main
part renamed 'process_timeout_or_friendly_check'.

Original comment by swbro...@gmail.com on 28 Jun 2009 at 7:26

Attachments:

• stasiscl-r260-friendly.diff

[GoogleCodeExporter]

Pinging this bug - patch still needs applied.  I've used it with all our raids 
since
this post and it works great.

Original comment by swbro...@gmail.com on 5 Aug 2009 at 12:28