Math error in calculating crit percentage

[GoogleCodeExporter]

While examining the stats for our mages on Brutallus I came across an
interesting error.

Manduned ; Scorch Hit 12, Crit 7 ; Crit% = 35.

Well, 7/19 = 36.8

However, there is also 1 resist in that 0/0/0/5/0 (5% resisted0

There was actually 20 scorches cast

7/20 = 35

I suppose the issue is ideology.  Do we count crit as a percentage of casts
that are started, or are landed?

I would prefer a 

Scorches (total 20) Hit 14, Crit 7, Miss 1 - Crit % 35.

That actually makes more sense when read.

Original issue reported on code.google.com by jon.j.ea...@gmail.com on 14 Aug 2008 at 7:58

[GoogleCodeExporter]

Looking for more comments on this issue. Basically what it comes down to is 
should the reported value be 1-roll 
crit or 2-roll crit? Right now it's 1-roll crit (n_crit / n_casts). 2-roll crit 
would be (n_crit / n_landed).

Original comment by gianmerlino@gmail.com on 12 Sep 2008 at 2:45

[GoogleCodeExporter]

I got SVN head out today 9/17...

I got the following from one parse:

Ability Eff. Heal Hits Crits Ticks Avg Hit Avg Crit Avg Tick Crit % Overheal % 
(-) Holy Light (r8) 58,950 26 24  3798 5711  92.3% 75.0% 

It shows 26 hits, 24 Crits, and a Crit % of 92.3% !!!! (92.3 = 24 / 26)
Crit % should be 24 / (26 + 24) = 48.0%

Original comment by shane.ha...@gmail.com on 17 Sep 2008 at 2:18

[GoogleCodeExporter]

This should be fixed now. Thanks for the catch, I didn't notice it since it 
only affected healing and not damage.

Original comment by gianmerlino@gmail.com on 16 Oct 2008 at 7:08

• Changed state: Fixed