search

teelolws / WhereTheZaralek

0 stars 2 forks source link

Option to disable event list #5

Closed ghost closed 1 year ago

ghost commented 1 year ago

Hello,

Thank you for the addon! Any chance we can get a toggle to disable this event list? I only want the pin and taskbar flash :) Thanks

image

teelolws commented 1 year ago

Yeah this is something I'm working on. The plan is to hide it during edit mode like this:

image

ghost commented 1 year ago

Wonderful thank you!

ghost commented 1 year ago

Update after some testing - the option to hide it does not persist. List shows up again. Also, the window in edit mode feels very awkward to use tbh. Too many unnecessary clicks - why have 2 windows? Its weird that this is even a part of edit mode tbh - all other addons do this via regular settings which makes more sense. Just my 2 cents. Thanks.

teelolws commented 1 year ago

The second click is because I cannot do conditional edit mode - it would show up even if you're not in Zaralek Caverns.

Why Edit Mode? I needed to provide a way to move it, and I've previously already written code to hook more frames into Edit Mode to do so

I'll do some testing about the hide issue.

teelolws commented 1 year ago

Found the problem - code to hide it was lost during a code merge with another developer yesterday: https://github.com/teelolws/WhereTheZaralek/commit/5c441cafc27b6d08fde2c89173e585b900158aea#diff-c845180126d2e68b0d6cc254312caa5a23e1ad57d7f7dcac1ae9d011eb51938b

ghost commented 1 year ago

Thank you :)