Fetch whole tree using utils.get_remote_tree

teemtee / fmf

Flexible Metadata Format

GNU General Public License v2.0

22 stars 28 forks source link

Fetch whole tree using utils.get_remote_tree #115

Closed lukaszachy closed 3 years ago

lukaszachy commented 3 years ago

Moved fetching of the tree to utils, closer to where it belongs. Tree.node just uses this function,

Main main goal is to use this function from wow (and cache results) so fmf seems a better place to take care of locking (as should operate on fmf cache).

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging e9ddcb7187581869304d1684b7cb5f4d551624c2 into 4aa72f4fee0f5918485afef40a924dea619d984c - view on LGTM.com

new alerts:

1 for Unused import

psss commented 3 years ago

Yeah, makes sense to keep both fetching the repo and the tree under utils. Thinking about the name... to make it consistent... as this is related to fetching remote objects, what about calling it fetch_tree()? Would be better if the other one could be fetch_repo() to make the distinction clear (and keep fetch() backward-compatibility for some time). What do you think?