teemtee / fmf

Flexible Metadata Format

GNU General Public License v2.0

22 stars 28 forks source link

Support additions to context made by adjust rules for follow-up rules #222

Open happz opened 6 months ago

happz commented 6 months ago

Derived from https://github.com/teemtee/tmt/issues/2706:

adjust:
  - when: distro == rhel-9
    context+:
      llvm: 19

  - when: llvm == 19
    ...

Since fmf does not recognize context, this might need a combined effort of tmt and tmt, e.g. fmf accepting a callback updating context, or a list of keys affecting context...

No idea how messy this can get. Plus, I recall seeing similar questions in the past, there might be issues with discussions somewhere. Yet, it might be nice to give it more thought.

happz commented 6 months ago

Summary from today's hacking meeting:

Order of the evaluation

The adjust rules would have to be defined in the right order so that the added context dimension is defined early enough during the adjust rules application (single fmf node can have definition at 3 locations thanks to elasticity)
There could be several run-throughs, during the first pass we could just evaluate rules which are modifying the context dimensions
- This would not work if the expectation is that the changes should be applied to selected fmf subtrees only
- Changing context for follow-up rules seems to be good enough, no expectation of multiple passes

The original use case seems to be ok with change in the current set of rules only