Open kkaarreell opened 2 weeks ago
$ cat main.fmf
discover:
- how: fmf
url: https://github.com/project1
- how: fmf
url: https://github.com/project2
/basic:
summary: Quick set of basic functionality tests
discover+*:
filter: "tier:1"
/features:
summary: Detailed tests for individual features
discover+*:
filter: "tier:2"
$ fmf show
/basic
discover: [{'filter': 'tier:1', 'how': 'fmf', 'url': 'https://github.com/project1'},
{'filter': 'tier:1', 'how': 'fmf', 'url': 'https://github.com/project2'}]
summary: Quick set of basic functionality tests
/features
discover: [{'filter': 'tier:2', 'how': 'fmf', 'url': 'https://github.com/project1'},
{'filter': 'tier:2', 'how': 'fmf', 'url': 'https://github.com/project2'}]
summary: Detailed tests for individual features
Just a thought, if we go with the *
operator, I think it would be better for it to be *+
So, after reading through the original issue it seems there are more people favoring using the +
operator.
With that in mind, I have pushed another commit which modified the code so that only +
is used.
I like this option more (if you want to compare both variants see the 1st commit only).
Moreover, now the following use case seems to be handled as well:
discover:
how: fmf
prune: True
adjust-tests:
- duration+: '*3'
when: hw == slow
/path:
discover+:
- name: upstream
url: https://some.url
- name: downstream
url: https://other.url
$ fmf show
/path
discover: [{'adjust-tests': [{'duration+': '*3', 'when': 'hw == slow'}],
'how': 'fmf',
'name': 'upstream',
'prune': True,
'url': 'https://some.url'},
{'adjust-tests': [{'duration+': '*3', 'when': 'hw == slow'}],
'how': 'fmf',
'name': 'downstream',
'prune': True,
'url': 'https://other.url'}]
@psss Hi, I do not plan any further updates unless requested. Please review.
/packit retest-failed
@psss Hi, could you please check failing tests? It doesn't seem related, rather like a change in Fedora distro that is not reflected in tests. Thank you.
it is questionable if we really need a new operator. Can't we simply stick to
+
?