search

teemtee / tmt

Test Management Tool
MIT License
85 stars 126 forks source link

Have useful selinux status output in provision data #3364

Open KwisatzHaderach opened 1 week ago

KwisatzHaderach commented 1 week ago

For now have selinux: yes which is taken from /proc/filesystems, this seems like a weird choice since even on my system with selinux disabled this file contains the string selinux causing tmt provision to think my system has selinux enabled (or yes, whatever that is supposed to mean :) ).

It would be great if there would be an actual state and mode, so we know if selinux is permissive or enforcing.

happz commented 1 week ago

For now have selinux: yes which is taken from /proc/filesystems, this seems like a weird choice since even on my system with selinux disabled this file contains the string selinux causing tmt provision to think my system has selinux enabled (or yes, whatever that is supposed to mean :) ).

In this context, selinux: yes means SELinux is enabled. Running restorecon will not explode. This is true even if it's (temporarily...) set to permissive mode.

It would be great if there would be an actual state and mode, so we know if selinux is permissive or enforcing.

For tmt this particular information was not important, as long as SELinux is enabled, tmt tries to behave nicely as if the user would switch to enforcing mode at any moment. I think it can be added, but IMO it fits the category of "system report", together with many other bits like "currently installed packages", "available repositories" or "HW configuration". Maybe we could have a plugin to gather this info in general, at one place.