teemuatlut / TMC2130Stepper

Arduino library for Trinamic TMC2130 Stepper driver
MIT License
159 stars 50 forks source link

TMC2130: SDI and SDO swapped in Fritzing PCB view #56

Open eyer1951 opened 5 years ago

eyer1951 commented 5 years ago

In the PCB definition, the Fritzing part for TMC2130 has SDO and SDI swapped. I had some boards manufactured, unfortunately.

In this example i just connected DIR to SDO to illustrate the issue. bad2130pcb.zip

teemuatlut commented 5 years ago

@soswow

eyer1951 commented 5 years ago

Oy! CS and SCK are also swapped.

teemuatlut commented 5 years ago

I'm not that familiar with Fritzing but everything looks good to me. Something I'm missing?

eyer1951 commented 5 years ago

Thanks for checking. Can you open the sketch file I provided? If so, you will quickly see that the PCB design does not match the TMS2130 icon shown in the breadboard (part layout). Pin locations for PCB wiring don't match the part. The location of the SDO connection (should be in the middle of the row) in the PCB layout is shown (wrongly) as 2nd from the end of the part (location of SDI). There is a simplified parts editor in Fritzing, but i could not fix this. Also note, CS and SCK are swapped. It appears @soswow was the author of the Fritzing parts file.

teemuatlut commented 5 years ago

Now I see the issue! I think the order of named pins need to be changed in the Connecters tab.

EDIT: After reordering image

eyer1951 commented 5 years ago

I tried renaming them in the Connectors tab, but that didn't work. I couldn't get Schematic, Breadboard, and PCB to synchronize correctly. '

eyer1951 commented 5 years ago

How did you accomplish the reordering? Exactly. Will you publish the corrected Fritzing part? Thanks.

eyer1951 commented 5 years ago

I did figure out how to associate each connections with the "icon" (holes on the part). I had not seen how to enable the menu with the checkmarks and "select graphic." So, for my own use, i now have a part that works. It would be nice if the "official" one were to be corrected and re-published.

soswow commented 5 years ago

I'll look into that today. Sorry for swapping (

On Tue, Nov 6, 2018, 17:49 eyer1951 notifications@github.com wrote:

I did figure out how to associate each connections with the "icon" (holes on the part). I had not seen how to enable the menu with the checkmarks and "select graphic." So, for my own use, i now have a part that works. It would be nice if the "official" one were to be corrected and re-published.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/teemuatlut/TMC2130Stepper/issues/56#issuecomment-436148654, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGmIW4xmKiQUuBpNEJIi_c0pGlNaZqNks5usTDmgaJpZM4YO_RH .

soswow commented 5 years ago

raised a PR