search

teemuatlut / TMC2208Stepper

GNU General Public License v3.0
69 stars 23 forks source link

Add shared UART with analog commutator and ChipSelect pin #2

Open byebyedizzy opened 6 years ago

byebyedizzy commented 6 years ago

Small patch to enable use of shared UART with analog commutator like 77HC4066 for multiple TMC2208 drivers. This might be suitable for platforms like Arduino Due which don't have software UART library implementations. In this scenario drivers should be connected as shown on TMC2208 datasheet (https://www.trinamic.com/fileadmin/assets/Products/ICs_Documents/TMC220x_TMC222x_Datasheet.pdf), page 22, figure 4.2. And ChipSelect pins (port pins in the datasheet) should be defined and used in TMC2208Stepper class constructors. Examples compile for both avr and due architectures, so I guess, that "avr-only" limitation can be shifted.

teemuatlut commented 6 years ago

Looks good. I'll merge it soon and then make some minor stylistic changes.

byebyedizzy commented 6 years ago

I'm testing this patch with Arduino Due, 74HC4066, 74HC125 and a bunch of 2208 (4 pieces). That turned out to be more tricky than I expected, so please postpone merge a little bit ... My guess is that additional buffer (74hc125) may affect reading from drivers, so I have to investigate the matter. I will let know of the result.

byebyedizzy commented 6 years ago

Well, preliminary tests (like in examples folder) on Arduino Due are over and successfull. Though I have to admit, that wasted 3 days just because though that if function returns boolean then it is an indicator whether it succeeds or no. But turned out that it's not always true :). I'm talking about functions that read driver's registers and return 0 if CRC is ok and 1 otherwise. May be this should be clarified in the readme ?

teemuatlut commented 6 years ago

I believe it's quite common for 0 to be "ok" and then 1, 2, 3.. to be different errors. Anyway, the TMC2208 behavior will be changed to conform to the TMC2130Stepper for the universal TMCStepper library.

byebyedizzy commented 6 years ago

Well, I assumed (as per readme) that boolean true == CRC is okay. But speaking of universal library - do you plan to merge this PR or will (or will not) integrate the code for shared UART in the universal library ? And when are you going to release this new library ? The thing is - I want to use 2208 drivers and shared UART on Due with Marlin (and send a PR to Marlin for that) and this will not be possible until you merge this PR ...

teemuatlut commented 6 years ago

The TMCStepper is already pushed on github but it's still WIP and I haven't added it to the Arduino Library Manager. At first I aim to support TMC2130, TMC5130 and TMC2660. Then TMC2208 and TMC2224 come after because they use UART instead of SPI. The new library will support everything the old ones do but the interface will change a bit for UART communication. It'll be some months before everything is nicely set up with it and the old libraries will of course be available. It's mostly a matter of where I will put my effort and where new features will be made. Also when it's working properly, Marlin will also change to that.

I can merge this later this week and it'll also be part of the TMCStepper library in the future.

byebyedizzy commented 6 years ago

My fault - I'm new to github and mistook "popular" for "all" repos. Will look forward for new library! Thanks a lot!