smhmd
commented
4 years ago Thank you for this.
About search, there is a lot of duplication going on right now and I want to change how we pull icons entirely (i.e. not import them as Vue components but use a sprite.)
I'll try to remove the duplication (for now) today, but key things are:
- We append
outline-solid-to icons because icons are imported as Vue comps and some of them have HTML element names which error out. (see https://github.com/teenyicons/teenyicons.com/blob/master/plugins/icons.js#L20) - We remove those prefixes while displaying the icons using replace in computed properties also used to filter by the search input while lowercasing everything to match. (See https://github.com/teenyicons/teenyicons.com/blob/master/pages/index.vue#L107-L124)
If you have any other questions, feel free to ask. I will try to comment things as they are now.
Again, I appreciate the PR :raised_hands:
briannhinton
I want to do more for the search, but I need to sit down and review how it all works first.