search

teepluss / laravel-hmvc

HMVC is a tool for making internal request.
76 stars 20 forks source link

Update Hmvc.php #16

Closed code-karma closed 9 years ago

code-karma commented 9 years ago

I believe this should be updated unless this hmvc release targets old Laravel versions: https://github.com/laravel/framework/issues/2919

code-karma commented 9 years ago

Not sure why this was closed without a fix... This issue still exists in the teepluss/laravel-hmvc (including v1.x branch). The package is unusable in Laravel without that fix. https://github.com/laravel/framework/issues/2919

phazei commented 9 years ago

I'm using the v1.x branch on Laravel 4.2 without issue

code-karma commented 9 years ago

Yes, I just checked the Laravel Router.php. It is working for any Laravel 4.2 or later but is not working wothout a fix in earlier versions as 'getCurrentRoute()' function does not exist there, just the 'current()' does.

The 'current()' function does exactly the same thing (all later versions have both functions doing the same thing with different name) therefore changing it in this package to current() would solve the issue for all.