Open minhnimble opened 2 years ago
teerox
commented
2 years ago Hi, Also a pleasure here to have my code reviewed by you😎, about my decision yea i will start by saying was an interesting project thou the time given wasn't enough but i pulled a really strong one here, trying to maintain a good architecture and wrote as much unit test cases as possible. I'm open to as many feedback as possible to improve and get better. Thank you👍
minhnimble
commented
2 years ago Good afternoon, Anthony 👋
I completed the 1st round of review just now. Thank you for your quick response on the UI issues, I will take a look and reply to you as soon as I am available. For now, please go ahead and let me know your thoughts on the remaining issues as well in the next couple of days, our HR will follow up with you if you have any questions about the code review timeline. 🚀
Have a nice weekend ☀️
Hello Anthony 👋 , it is a pleasure to meet you through this code review session and thank you for your effort on the code submission. My name is Mikey, I am currently acting as an Engineer Lead from Nimble and I am happy to be the reviewer for our code review session.
During the review process, we would like to know more about your decisions and thus I will create issues where I think there could be more improvements regarding your performance here.
At the same time, please keep in mind that this is a bi-directional process and we would love to hear back from you as well. Therefore, don’t hesitate to raise your questions/concerns and share your opinions about the implementation (if any) during the process.
If we’re aligned on any issue here and you’d like to correct them, please address the issue using proper git flow (creating a new branch, opening a Pull Request (PR) per issue and merging the code when you are ready) and I will follow up on those fixes. 😇 In the end, I really do hope that you find the process enjoyable. Good luck and happy coding 🤘