teetime-framework / TeeTime

The Java reference implementation of the Pipe-and-Filter framework TeeTime
http://teetime-framework.github.io
Apache License 2.0
20 stars 5 forks source link

Move hamcrest to test scope and test classes to test folder #22

Closed DaGeRe closed 2 years ago

DaGeRe commented 2 years ago

If would be nice, if all test sources are in test and if hamcrest would not be included in the build, since it is outdated and a testing library (like pointed out for maven in https://github.com/teetime-framework/TeeTime/pull/10).

rju commented 2 years ago

This change has the issue that the test classes are not shipped. However, they provide necessary classes used in testing TeeTime stages.

DaGeRe commented 2 years ago

Thanks for the merge.

However, somehow old JUnit 4.13 (instead 4.13.2) sneaked into the commit: https://github.com/teetime-framework/TeeTime/blob/788818c976c37295909d09e73b564c74ba0491c8/build.gradle#L26 Maybe you could just push a commit changing back to 4.13.2.