teeworlds / teeworlds-translation

Language files for teeworlds - we use transifex, please read the wiki
https://www.teeworlds.com/forum/viewtopic.php?id=12573
Other
28 stars 36 forks source link

Gaelic Scottish needs a flag and Scotland isn't in ISO 3166-1 #59

Closed Dune-jr closed 6 years ago

Dune-jr commented 6 years ago

The problem is that Scotland does not have an ISO 3166-1 code but it has a flag in Teeworlds, so technically we could use it.

I was forced to give the UK flag for now, which is confusing because English uses the same:

screenshot_2018-11-10_22-05-26

Unless I'm mistaken on something, this seems like a code issue to me - alphabetic flag codes should probably be used instead of their numeric counterparts.

Dune-jr commented 6 years ago

@oy should we have another way of referring to flags than their ISO 3166-1 code, since some flags do not have such a numerical code?

oy commented 6 years ago

There're custom entries for countries which don't have an ISO 3166-1 code. https://github.com/teeworlds/teeworlds/blob/master/datasrc/countryflags/index.json#L16 That's the scottish one

Dune-jr commented 6 years ago

Ah, thanks @oy :)