search

teeworlds / teeworlds-translation

Language files for teeworlds - we use transifex, please read the wiki
https://www.teeworlds.com/forum/viewtopic.php?id=12573
Other
28 stars 36 forks source link

Belarusian and Russian translations for mainline version #70

Closed ArionWT closed 5 years ago

ArionWT commented 5 years ago

Merged from transifex and added missed strings for body, marking, decoration, feet, hands and eyes.

Dune-jr commented 5 years ago

Hello,

Thanks for your contribution. We usually keep all the translation work at Transifex, and regularly export and import strings in and out of Teeworlds.

In order to export Transifex strings, we use this script: reconvert_l10n.py (which includes the old normalize.py) as described here: https://github.com/teeworlds/teeworlds-translation/wiki. It seems like your commits do not use a recent script (there is a huge diff).

The problem when you directly PR changes here is that they would get overridden by changes later over at Transifex, so it is better to keep everything there.

I will export the new strings to Transifex now so you can port those changes.

Dune-jr commented 5 years ago

Transifex was updated with new strings, and this repository was updated with all changes on Transifex.

ArionWT commented 5 years ago

Hello,

It seems like your commits do not use a recent script (there is a huge diff).

Script was taken from this post. Apparently it is outdated. Thanks for the information.

Transifex was updated with new strings

At the bottom of the files in PR were added lines that are not present on Transifex (for example). Which is strange, because after adding them, the translation is applied in the game.

Dune-jr commented 5 years ago

Hello,

It seems like your commits do not use a recent script (there is a huge diff).

Script was taken from this post. Apparently it is outdated. Thanks for the information.

Ah, sorry. I made the link stay up to date with master (it was linking a specific commit).

Transifex was updated with new strings

At the bottom of the files in PR were added lines that are not present on Transifex (for example). Which is strange, because after adding them, the translation is applied in the game.

So this is either an issue with the Teeworlds code (some strings are not localized in a good way), or you are using a 0.7.2 client that does not use the new strings (like the latest client from https://github.com/teeworlds/teeworlds/ does). I will test and report.

ArionWT commented 5 years ago

Created an issue #71, since this PR has no more sense.