search

teeworlds / teeworlds-translation

Language files for teeworlds - we use transifex, please read the wiki
https://www.teeworlds.com/forum/viewtopic.php?id=12573
Other
28 stars 36 forks source link

Some strings are missing for translation #71

Open ArionWT opened 5 years ago

ArionWT commented 5 years ago

Hello, There aren't some strings for translation on Transifex:

Server
body
marking
decoration
hands
feet
eyes

(screenshots on Imgur)

If you add them to the .json file manually, translated strings works in the game (at least in version 0.7.2). Maybe this is some kind of bug in some convert script for loading on Transifex?

Dune-jr commented 5 years ago

Forwarded to https://github.com/teeworlds/teeworlds/issues/2027 since this is a code issue

Dune-jr commented 5 years ago

Fixed by https://github.com/teeworlds/teeworlds/pull/2029, updated Transifex

ArionWT commented 5 years ago

Seems other two strings don't work in the new menu: All in src\game\client\components\menus.cpp:2532 Favorites in src\game\client\components\menus.cpp:2530 They are in .json file, but not applied ingame. _2019-02-10_00-06-49

Dune-jr commented 5 years ago

Those are filters defined in ui_settings.json. Since filters can be customized by the user (but not really those), it would be difficult to localize them.

@oy should we change that somehow and localize the default filter names, or leave it as is?

oy commented 5 years ago

@Dune-jr yeah, we could localize them.

ArionWT commented 5 years ago

Hello, Missed one string on Transifex: Menu background transparency

And string №336 You have to wait %1.f seconds to change identity. on Transifex may be You have to wait %1.0f seconds to change identity. due this commit.

Dune-jr commented 5 years ago

Yeah, need to update Transifex for the menu background transparency. The second thing isn't a big deal, I can automate a fix.