teeworlds / teeworlds

A retro multiplayer shooter
https://www.teeworlds.com
Other
2.37k stars 638 forks source link

Changing skin only take effect when you change the server #1350

Closed Zwelf closed 9 years ago

Zwelf commented 9 years ago

It would be great, if the skin change, when you change it in the options, like teeworlds 0.6 does it.

Henningstone commented 9 years ago

Having it like it is now makes skin-changing or tee-faking bots impossible, though.

heinrich5991 commented 9 years ago

You can still reconnect using a faked skin. Also, such a "bot protection" should not go against the UX.

Henningstone commented 9 years ago

Do you know Chameleon? This bot changes your tee data (so your name and Clan and skin and everything) to the tee data of the tee you hit, whenever you hit a tee. Something like that is what I meant in my previous post. Usual players have no reason to change their skin all the time while playing, do they? :O

heinrich5991 commented 9 years ago

Not all the time, but not being able to change your skin while in-game is bad for new users who experiment or users who like to change their skin once in a while.

Maybe more aggressive timeouts should be put in place.

oy commented 9 years ago

Won't fix. This was pretty much just abused anyway and the skin selector provides a preview.

Zwelf commented 9 years ago

It is better to make this option configurable from the server. Skin changing is like changing the name. Do user need to change their name? Yes they do the same way they want to change theire skin. And changing skin shouldn't be disabled neither. There should be a better protection if it is enabled.

Henningstone commented 9 years ago

Hmm, "make it configurable" seems to be always the best solution for programmers, does it? We can't make false decisions if we leave every decision to the user :) Ok but seriously: in this case I think that it might be the best solution. Change-botting the name is even more annoying because it is being announced in chat (but possible yet anyway). Server owners who feel disturbed by eventual skin changing botters can turn instant skin change off before they need to start crying :/ In fact, quite everything can be abused in some way, but usual players shouldn't be affected by the consequences of "fixing" that. Just my personal opinion.

heinrich5991 commented 9 years ago

@Henningstone The chat can also be spammed in other ways, chat messages, join/leave spamming, etc. :)

Henningstone commented 9 years ago

@heinrich5991 Mhh I forgot that vanilla has no feature to automatically mute players who are spamming chat messages :0 I think I play to less vanilla and to much modded teeworlds. My mistake :D

Zwelf commented 9 years ago

What about only change the skin, if the character repawn. In my opinion this is a good solution, because it is as well a skin change protection and it would be a compromise that you can change your skin ingame. I hope this issue will be reopened and this bug will be fixed.

nheir commented 9 years ago

I feel like this is a feature and not a bug, looking at code. But, this also prevents using skin changes on server side (that one can see with zcatch)… Maybe the client should trust the server and shouldn't assume that ClientInfo == new client.