teeworlds / teeworlds

A retro multiplayer shooter
https://www.teeworlds.com
Other
2.38k stars 636 forks source link

Inputs get stuck in the rc #1761

Closed ChillerDragon closed 5 years ago

ChillerDragon commented 5 years ago

I just tested the windows 64bit rc and i realized that the inputs get stuck very often. Sometimes i am not able too hook then it keeps hooking and shooting even if i press nothing.

I downloaded it from the release page and told windows that teeworlds should overwrite the scaling to have less bugs on 4k screen.

Dune-jr commented 5 years ago

That sounds related to the 4k/scaling stuff. Can you try on a non-4k screen? Or just change the resolution of your desktop to check.

ChillerDragon commented 5 years ago

I tried on a regular fullhd screen it had the same result.

savander commented 5 years ago

Input stuck when you press shift (the circle with emoticons). You can't do anything then. Also, if you press, for example, move-right, and release that move while holding the circle, the player keep moving. etc. (it keeps moving, even if you release shift button)

ChillerDragon commented 5 years ago

@savander you genius! Yes it is a emote bug. And i press shift all the time. It is not just the emote circle. Also bind lshift emote 7 direct emotes stuck the input.

ChillerDragon commented 5 years ago

Oh it has actually nothing to do with emotes it is the shift key. @Dune-jr it might be related to the compose binds https://github.com/teeworlds/teeworlds/pull/1589

Dune-jr commented 5 years ago

Sounds like it is related to #1589 indeed. I'll have a look.

Dune-jr commented 5 years ago

One issue is that pressing Shift+D is not meant to trigger D binds (and thus you will no longer move right). That is an issue if, for example, lshift is bound to emotes.

I'm looking for a good solution to this.

oy commented 5 years ago

Binds for which you keep the button pressed (starting with +) should just be allowed to be bound to single keys and should always be triggered despite any modifier.

Dune-jr commented 5 years ago

@oy that sounds like a clever fix.