search

teeworlds / teeworlds

A retro multiplayer shooter
https://www.teeworlds.com
Other
2.37k stars 638 forks source link

The 0.7 server popup is too small for the text #1843

Closed Dune-jr closed 5 years ago

Dune-jr commented 5 years ago

image

sepulzera commented 5 years ago

Imo we could remove the hash info. It is way too technical for the common user. Wrong version. Server is running '0.7' and client '0.7 DDNet'.

The mods developer should be responsible to set the version string properly, if compatibility breaks.

Dune-jr commented 5 years ago
  1. It's a problem with other messages, not just hash
  2. Mods shouldn't put info in their hash, that's not what it's for. It's to check for protocol incompatibilities and prevent very strange behaviors.
sepulzera commented 5 years ago
  1. For instance?
  2. You can check for protocol compatibility without displaying "random" numbers to the end user ;-) They are of no value except for devs.
Dune-jr commented 5 years ago
  1. For instance?

I suspect if the popup window doesn't act nice with this message, it won't act nice with others. I vaguely remember this problem, but I don't have an instance to show off.

  1. You can check for protocol compatibility without displaying "random" numbers to the end user ;-) They are of no value except for devs.

Ah, so you meant changing the error message, I thought you meant scrapping the feature.

I guess it could say something like Protocols mismatch, server version incompatible. But having the hashes be displayed is very helpful to troubleshoot problems when those screenshots appear in support, so I don't think I like removing the hashes too much.

nheir commented 5 years ago

Let the full message in console then.

There is space in the dialog box, so for any other message that does not fit, it should break into two lines.