Get Subscriptions for a Customer

teference / zoho-dotnet

Zoho API .NET SDK

MIT License

7 stars 11 forks source link

Get Subscriptions for a Customer #2

Closed ultimaustin closed 7 years ago

ultimaustin commented 7 years ago

Hi,

I've made a tiny change to the ZsSubscriptionApi.GetAllAsync methods to allow a ZsCustomer to get specified on the get.

Would you be willing to bring this change into your master branch?

Many thanks, Matt

jsinh commented 7 years ago

@ultimaustin Sure, I had the filters on radar to add but did not got much time to start on it.

Accepting this PR, but I already got a pattern to follow for adding filters to API call. E.g: https://github.com/teference/zoho-dotnet/blob/master/source/Zoho.Api/Impl/ZsInvoiceApi.cs#L93-L115

In this example I am using ZsInvoiceFilter enum to specify filter type and its value. I will modify the PR to that pattern and push a NuGet release, Thanks for reaching out, Cheers!

jsinh commented 7 years ago

@ultimaustin - Pushed to NuGet https://github.com/teference/zoho-dotnet/releases/tag/v0.6.14 https://www.nuget.org/packages/Zoho.Api/0.6.14

Cheers!