search

tefkah / zotero-night

Night theme for Zotero UI and PDF
GNU General Public License v3.0
2.42k stars 38 forks source link

[BUG] reversed image color using Zotero on mac in dark mode #142

Closed jackhu-bme closed 1 year ago

jackhu-bme commented 1 year ago

Describe the bug

image

The image shown is in reversed wrong color in dark mode. The correct color is shown as follows in light mode:

image

To Reproduce Steps to reproduce the behavior:

  1. Go to Zotero on mac
  2. Click on "tools", "night preferences", choose "dark"
  3. restart Zotero and watch a image
  4. See error

Expected behavior change only the background color, keep the image color unchanged.

Screenshots offered in the bug part.

OS (MacOS XX.xx [specify Intel or Silicon], Windows, Linux [specify distro/package type]: macos Silicon only tested, with bug

Zotero Night version (please check that you are on the latest version) the latest version 0.4.23 for Zotero 6.

Additional context This sets great barrier for me when reading papers in pdf, a researcher in computer vision as the image color is too essential for visualizing the results. Sincerely thanks, please help me how to Solve It when available.

jackhu-bme commented 1 year ago

The pdf is downloaded from pdgan . You can use it for testing.

tefkah commented 1 year ago

I agree that this would be nice, but unfortunately it is probably not possible.

Reason being is that I can only really affect the page in it's entirety, I cannot target specific elements of the page like the text or the images. PDFs are basically implemented as a series of images, which means that the only way to change them here is by applying a big filter which, as you can see, inverts the background and the images and the text.

So I can't help you, sorry! There is limited ability to change only the background color of the page, but I cannot change the text and images separately.

I'm happy to be proven wrong though! If you can point to a pdf reader that has dark mode without affecting the images I'll try to see what they do!

jackhu-bme commented 1 year ago

I understand it now. That's why I can hardly find any PDF reader with dark mode that satisfy my request. Actually, I know little about this, how pdf is organized and so on. As a simple joke, maybe one day, when AI algorithm that detects needed images and splits needed image region and the background, is integrated into pdf reader, this could be implemented. I don't know how much work it takes actually, to be honest. Again, thank you for your detailed clarification!