tefkah / zotero-night

Night theme for Zotero UI and PDF
GNU General Public License v3.0
2.42k stars 38 forks source link

[BUG] Night mode don't apply on PDF #148

Open Meonthb opened 1 year ago

Meonthb commented 1 year ago

Describe the bug Night mode don't apply on PDF in Zotero 7

To Reproduce Steps to reproduce the behavior: Toggled the night mode icon, only the UI turned into dark, but not the PDF.

Screenshots image

OS (MacOS XX.xx [specify Intel or Silicon], Windows, Linux [specify distro/package type]: Windows 11 version: 22H2 OS build: 22621.2215 Experience: Windows Feature Experience Pack 1000.22662.1000.0

tefkah commented 1 year ago

Are you using the latest version of the plugin? The first release for Zotero 7 had that problem

Meonthb commented 1 year ago

Are you using the latest version of the plugin? The first release for Zotero 7 had that problem

Yes, I'm using the latest version 0.1.0-1 image

tefkah commented 1 year ago

thanks for double checking! this might be a windows version problem then, which is kind of hard for me to check. If other people have this problem on Windows 11 please let me know!

tefkah commented 1 year ago

Oh and which version of Zotero are you running?

Meonthb commented 1 year ago

Thank you for your work! I'm using the latest Zotero version 7.0.0-beta.39+ecba25be0 (64-bit)

sleepymalc commented 1 year ago

I do encounter the same bug. Every time I open a new pdf, it appears in a light theme (only for pdf; the rest of the UI is still in dark mode). I'll need to manually toggle the theme switch to make the pdf appear in the dark mode.

FlynnSpace commented 1 year ago

I get this situation too, when I open a pdf, it's still light, but the sidebar is dark. I try to find the button to change it, but it seems the button is missing XD image

tefkah commented 1 year ago

@FlynnSpace Seems like you are using the Zotero 6 version, what version of the plugin of the plugin are you using?

tefkah commented 1 year ago

For the people on Zotero 7, please try the latest release

FlynnSpace commented 1 year ago

@tefkah The plugin is 0.4.23 and the Zotero is 6.0.27. Should I download the old version plugin or Zotero?

jiagengliu commented 1 year ago

I had the same problem on mac, but restarting Zotero solved the problem.

zgz292dev commented 1 year ago

I have the same problem on Windows 11. OS build : 22621.228

kzssc commented 1 year ago

Mac 13.5.2 Night 0.1.0-2 2023-09-12 11:55:51 7.0.0-beta.40+24ae34104

Can confirm that sometimes dark mode works for some PDF, but not all. This can be rectified by closing the document and then re-open from within Zotero. Re-opening Zotero does not rectify the issue.

csy94cfy commented 1 year ago

@tefkah The plugin is 0.4.23 and the Zotero is 6.0.27. Should I download the old version plugin or Zotero?

hey dude, I have the same versions as you, have you solved your question?

franzbischoff commented 1 year ago

Mac 13.5.2 Night 0.1.0-2 2023-09-12 11:55:51 7.0.0-beta.40+24ae34104

Can confirm that sometimes dark mode works for some PDF, but not all. This can be rectified by closing the document and then re-open from within Zotero. Re-opening Zotero does not rectify the issue.

For me, some PDFs get dark. After some trials, seems to be related to the initial state of the "light/dark" button when you open the PDF. If you switch back to the star, close the pdf, reopen the pdf, then click again ob the button, it cycle light and dark correctly.

Again, some times it does not work like I said... then I kept the PDF opened, switch off the addon and on again, and voilá, dark... :-/

FlynnSpace commented 1 year ago

@tefkah The plugin is 0.4.23 and the Zotero is 6.0.27. Should I download the old version plugin or Zotero?

hey dude, I have the same versions as you, have you solved your question?

No, the background of all my PDFs still stings the eyes, even if I restart the plugin or Zetero. (╯ ͡❛ ͜ʖ ͡❛)╯┻━┻

franzbischoff commented 1 year ago

@tefkah The plugin is 0.4.23 and the Zotero is 6.0.27. Should I download the old version plugin or Zotero?

hey dude, I have the same versions as you, have you solved your question?

No, the background of all my PDFs still stings the eyes, even if I restart the plugin or Zetero. (╯ ͡❛ ͜ʖ ͡❛)╯┻━┻

Try the "disable/enable" trick while not fixed :)

FlynnSpace commented 1 year ago

@csy94cfy hey bro, I think I found the alternative solution from issue #128 . You can try the plugin "zotero-style", which is able to set the PDF's background to dark.

ruturajreddy commented 7 months ago

For me it worked by going to Tools -> Night preferences and enabling disabling the option for dark mode and selecting the option for the default pdf view. Working on Zotero 6.0.37.

This is what it should look like.

Screenshot 2024-04-02 at 5 30 12 PM