search

tefkah / zotero-night

Night theme for Zotero UI and PDF
GNU General Public License v3.0
2.38k stars 37 forks source link

Linux GUI controlled by GTK Theme #54

Open shjenkins94 opened 2 years ago

shjenkins94 commented 2 years ago

I think this is the cause of #37, #40 (on Linux), and #31. I also made a post on the Zotero forum

Basically I noticed that the parts of Zotero's UI that don't darken on Linux change if you change the GTK theme for applications. Here's a screenshot to show what I mean: Screenshot from 2022-07-17 22-34-14 This is Zotero in nightmode, and the GTK theme for applications is set to Gruvbox. You can see that the scrollbars, the top part of the window, and the menu items with checkboxes are all sepia-ish.

I tried messing around with the GTK theme (which also uses CSS) and zotero-night and my (not super knowledgeable) findings are:

  1. Neither zotero-night nor GTK can reach everything in Zotero's GUI. zotero-night can't get to the parts that I pointed out in the above screenshot, and GTK can't get the tabs or the PDF reader.
  2. If you take out the parts of the GTK theme that affect Zotero's GUI it looks awful.
  3. Taking out some of the the CSS code from zotero-night and applying a matching GTK theme would result in a completely themed Zotero on Linux. Like this: zotero-night over a Nordic GTK theme Screenshot from 2022-08-01 01-36-31

I'm not sure what to do about all this. It would be great if the parts controlled by GTK could somehow be put into the .xpi theme.

tefkah commented 2 years ago

From what I've seen I cannot change certain elements such as scrollbars from within Zotero using CSS as its using an old version of Firefox, unless I change all the scrollbars using JS, which I haven't been able to make work.

For the File menus: for these I'd love PRs! I don't have a Linux or Windows machine so testing this is kinda difficult