search

teheru / nczone

A match making plattform written primarily for Age of Empires II.
GNU General Public License v2.0
5 stars 9 forks source link

Support PHPBB 3.3 #64

Closed Sam152 closed 4 years ago

Sam152 commented 4 years ago

The only error I found when upgrading to 3.3 was the following:

TypeError: Return value of eru\nczone\utility\phpbb_util::container() must be an instance of Symfony\Component\DependencyInjection\ContainerBuilder, instance of phpbb_cache_container returned

Removing the typehint made the extension work. We could also hint phpbb_cache_container, however that would mean it wouldn't work on 3.2.

Sam152 commented 4 years ago

PR here: #65

Seltsamsel commented 4 years ago

Merged, thanks!