tehkillerbee / mopidy-tidal

Tidal Backend plugin for Mopidy
Apache License 2.0
93 stars 28 forks source link

ci: use personal codecov token to avoid rate limit. #109

Closed 2e0byo closed 1 year ago

2e0byo commented 1 year ago

This should fix the intermittent ci failures.

It does require action your side: you need to create a new secret called CODECOV_TOKEN with the token in it. The token can be copied from the codecov repo page (it's not an api token, apparently, having tried that), i.e. hopefully here: https://app.codecov.io/gh/tehkillerbee/mopidy-tidal/settings

And then you can make a new repository secret here: https://github.com/tehkillerbee/mopidy-tidal/settings/secrets/actions/new

Assuming that is I got those urls right. But it's not like you needed them anyhow, I just still had the tabs open.

See https://github.com/codecov/codecov-action/issues/557.

2e0byo commented 1 year ago

Incidentally I don't know what this will do to PRs; I guess we'll have to see. so long as the CI doesn't fail it doesn't really matter. If it does I'll make another pico-pr to skip codecov in prs. After all you get tons of prs ;)

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (303a550) 100.00% compared to head (f38a945) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #109 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 910 910 Branches 170 170 ========================================= Hits 910 910 ``` | [Impacted Files](https://codecov.io/gh/tehkillerbee/mopidy-tidal/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+L) | Coverage Δ | | |---|---|---| | [mopidy\_tidal/backend.py](https://codecov.io/gh/tehkillerbee/mopidy-tidal/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+L#diff-bW9waWR5X3RpZGFsL2JhY2tlbmQucHk=) | `100.00% <100.00%> (ø)` | | | [mopidy\_tidal/library.py](https://codecov.io/gh/tehkillerbee/mopidy-tidal/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+L#diff-bW9waWR5X3RpZGFsL2xpYnJhcnkucHk=) | `100.00% <100.00%> (ø)` | | | [mopidy\_tidal/playback.py](https://codecov.io/gh/tehkillerbee/mopidy-tidal/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+L#diff-bW9waWR5X3RpZGFsL3BsYXliYWNrLnB5) | `100.00% <100.00%> (ø)` | | | [mopidy\_tidal/playlists.py](https://codecov.io/gh/tehkillerbee/mopidy-tidal/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+L#diff-bW9waWR5X3RpZGFsL3BsYXlsaXN0cy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+L). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+L)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

2e0byo commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (303a550) 100.00% compared to head (f38a945) 100.00%.

mega This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files

umbrella View full report in Codecov by Sentry. loudspeaker Do you have feedback about the report comment? Let us know in this issue.

Ah, you might want to do this too... to give you even more work :D

tehkillerbee commented 1 year ago

Done and merged. Thanks!