search

tehkillerbee / mopidy-tidal

Tidal Backend plugin for Mopidy
Apache License 2.0
93 stars 28 forks source link

Add integration tests. #111

Open 2e0byo opened 1 year ago

2e0byo commented 1 year ago

Apparently

Deprecated field ‘track’ with the goal of removing it in the next major release, use ‘track_name’ instead. Backends should support both track and track_name until they require a version of Mopidy where track has been removed. src

I don't know if we do this, but I do know that we don't have a test for it. We need integration tests, preferably against a few versions of mopidy, with -Werror so we fail on deprecations.

@tehkillerbee this would be slightly easier to write (at least for me) if we were using poetry. If you'd be up for that I'll do it in the PR. But I'm perfectly happy to figure out how to do it without.

[Edit] I can't self-assign so adding here that I obv intend to write these myself unless anyone else wants to. Opening this issue just to keep track/allow conversation before the PR lands.

tehkillerbee commented 1 year ago

@2e0byo I am not familiar with poetry and I have no preferences so feel free to use it

FYI I have added both you and @BlackLight as collaborators, as it might make it a little more efficient as it should allow you to assign issues to yourself. Feel free to accept if you want.

2e0byo commented 1 year ago

Ta! I promise not to do anything stupid. Well, not intentionally anyhow ;)

2e0byo commented 1 year ago

Curiously having re-read mopidy code I don't think there is any way to trigger this deprecation warning, since we've overriden the method. I'm just going to fix it for now, but integration tests are on the way anyhow.