search

tehkillerbee / mopidy-tidal

Tidal Backend plugin for Mopidy
Apache License 2.0
93 stars 28 forks source link

Feature: Add HI_RES support, handle missing images gracefully #131

Closed tehkillerbee closed 1 year ago

tehkillerbee commented 1 year ago

This PR adds the following features:

2e0byo commented 1 year ago

hmm I think the tests might need looking at... ;)

2e0byo commented 1 year ago

@tehkillerbee I'll have a look at fixing this up in the next few weeks if you haven't by then. We should get the tests passing: the integration failure is probably indicative of a real regression somewhere in the public api surface. The unit tests might just need to match the api better: the problem with using mocks everywhere.

tehkillerbee commented 1 year ago

@tehkillerbee I'll have a look at fixing this up in the next few weeks if you haven't by then. We should get the tests passing: the integration failure is probably indicative of a real regression somewhere in the public api surface. The unit tests might just need to match the api better: the problem with using mocks everywhere.

@2e0byo I will try to fix the tests but it might take a while. If I cannot get it working, I might end up merging this PR so we can get HI_RES support added. Then I will fix the tests in a separate PR. Not ideal, of course :see_no_evil: