search

tehkillerbee / mopidy-tidal

Tidal Backend plugin for Mopidy
Apache License 2.0
93 stars 28 forks source link

Incorrect tests for nonexistent objects #137

Closed 2e0byo closed 7 months ago

2e0byo commented 1 year ago

See e.g. https://github.com/tehkillerbee/mopidy-tidal/blob/33b41e1f15a425fd983c172bacd48147a30f1fe2/mopidy_tidal/library.py#L395

This check is incorrect as tidalapi never returns anything falsy, but does raise an exception if an invalid album is accessed.

2e0byo commented 1 year ago

The recent typing work will actually catch these bugs, so that's good

tehkillerbee commented 7 months ago

Fixed in https://github.com/tehkillerbee/mopidy-tidal/pull/151