search

tehkillerbee / mopidy-tidal

Tidal Backend plugin for Mopidy
Apache License 2.0
93 stars 28 forks source link

Fix confusing quality log messages #163

Open fmarzocca opened 6 months ago

fmarzocca commented 6 months ago

I was looking at the log and found these lines:

Mar 19 16:58:17 pab mopidy[2154]: INFO     [TidalBackend-3 (_actor_loop)] mopidy_tidal.playback No HI_RES available for this track; Using playback quality: LOSSLESS
Mar 19 16:58:17 pab mopidy[2154]: INFO     [TidalBackend-3 (_actor_loop)] mopidy_tidal.playback Starting playback of track:96830423, (quality:HI_RES, codec:MQA, 16bit/44100Hz)

The first one states quality is LOSSLESS, the second reports quality as HI_RES... Which one is right? I checked with tidalapi and it reports HI_RES for this track.

tehkillerbee commented 6 months ago

This message refers to the fact that you requested HI_RES audio as the tidal quality but it was not listed/available in the metadata for that track. But now that we use the stream to get the quality, we should probably use that instead.

The actual quality used for playback will always be listed in the following log message: "Starting playback of track:96830423, (quality:HI_RES, codec:MQA, 16bit/44100Hz)"

FYI, if you want lossless quality, you should use HI_RES_LOSSLESS but maybe you prefer to use MQA instead?

fmarzocca commented 6 months ago

FYI, if you want lossless quality, you should use HI_RES_LOSSLESS but maybe you prefer to use MQA instead?

I have set HI_RES_LOSSLESS in mopidy.conf, but I believe the quality is defined by the specific playing track.