search

tehmaspc / puppet-magnum

https://rubygems.org/gems/puppet-magnum
Other
30 stars 13 forks source link

Workflow updates #53

Closed tehmaspc closed 6 years ago

tehmaspc commented 6 years ago

@ironhalo - Please review my latest commits. Thanks.

FYI - Still need to test out the workflow changes on my end.

tehmaspc commented 6 years ago

@ironhalo

Haven't been able to get any of the vagrant tests to run successfully via the vbox task (on both Ruby 2.5.0 and 2.4.1):

% be rake vbox up
/Users/tehmasp/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/beaker-rspec-6.2.3/lib/beaker-rspec/helpers/serverspec.rb:43: warning: already initialized constant Module::VALID_OPTIONS_KEYS
/Users/tehmasp/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/specinfra-2.73.1/lib/specinfra/configuration.rb:4: warning: previous definition of VALID_OPTIONS_KEYS was here
Beaker::Hypervisor, found some vagrant boxes to create
==> ubuntu-server-1604-x64: VM not created. Moving on...

An error occurred while loading ./spec/acceptance/nginx_spec.rb.
Failure/Error: require 'beaker-rspec'
RuntimeError:
  Failed to exec 'vagrant destroy --force'. Error was

# ./spec/spec_helper_acceptance.rb:2:in `require'
# ./spec/spec_helper_acceptance.rb:2:in `<top (required)>'
# ./spec/acceptance/nginx_spec.rb:1:in `require_relative'
# ./spec/acceptance/nginx_spec.rb:1:in `<top (required)>'
No examples found.

Finished in 0.00051 seconds (files took 1.82 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
tehmaspc commented 6 years ago

UPDATE: Looks like I was missing the vagrant-serverspec plugin for some reason which was causing my vbox task to not run.

tehmaspc commented 6 years ago

@ironhalo - I think this PR is ready to go now; let's chat about getting this merged. Thanks.

tehmaspc commented 6 years ago

merging