search

tehmaze / xmodem

XMODEM protocol implementation for Python
https://pypi.org/project/xmodem/
MIT License
98 stars 57 forks source link

ACK after receiving EOT #2

Closed napanorton closed 10 years ago

napanorton commented 10 years ago

It looks to me that after the EOT is recv'd the sender expects an ACK. In your code, the method returns the incoming byte count, but no ACK. Can you confirm this is a bug?

Thanks! David

krishardy commented 10 years ago

Hi David,

Yes, that is a bug.

I can probably go through the code tonight and fix it. If you want to post a patch, feel free.

Thanks! -Kris

On 01/05/2014 09:25 AM, David Goldman wrote:

It looks to me that after the EOT is recv'd the sender expects an ACK. In your code, the method returns the incoming byte count, but no ACK. Can you confirm this is a bug?

Thanks! David

— Reply to this email directly or view it on GitHub https://github.com/tehmaze/xmodem/issues/2.

krishardy commented 10 years ago

I have just pushed a patch.

The XMODEM receiver now sends an ACK after receiving the EOT The XMODEM sender expects an ACK after sending the EOT

tehmaze commented 10 years ago

Thanks guys, released XMODEM 0.3.2 with these patches included today.

napanorton commented 10 years ago

Thanks!!!

--David Torturously pecked out on my iPhone.

On Jan 5, 2014, at 2:17 PM, Kris Hardy notifications@github.com wrote:

Hi David,

Yes, that is a bug.

I can probably go through the code tonight and fix it. If you want to post a patch, feel free.

Thanks! -Kris

On 01/05/2014 09:25 AM, David Goldman wrote:

It looks to me that after the EOT is recv'd the sender expects an ACK. In your code, the method returns the incoming byte count, but no ACK. Can you confirm this is a bug?

Thanks! David

— Reply to this email directly or view it on GitHub https://github.com/tehmaze/xmodem/issues/2.

— Reply to this email directly or view it on GitHub.