search

tehmaze / xmodem

XMODEM protocol implementation for Python
https://pypi.org/project/xmodem/
MIT License
99 stars 57 forks source link

On CRC checksum failure and block re-transmission, send() calls getc() for next block #7

Closed jquast closed 8 years ago

jquast commented 9 years ago

Needs a test, but I discovered while working through some porting issues that when xmodem.send receives a NAK for retransmission -- although acknowledged, it still subsequently calls self.getc() for the next block -- thereby skipping a sequence block all-together.

jquast commented 9 years ago

this is for xmodem.recv, actually -- and it is because the start-header is not re-received for the next block. fix upcoming.