search

tehp / OpenPoGoBot

A PokemonGo Python bot - NO LONGER MAINTAINED
MIT License
123 stars 53 forks source link

Config mode and bot behavior #130

Closed 1karu5 closed 8 years ago

1karu5 commented 8 years ago

Expected Behavior

If i set mode in config to "all", i expect that the bot wont change it.

Actual Behavior

If my bag is full, the bot changes mode to "poke" (https://github.com/OpenPoGo/OpenPoGoBot/blob/64768648983982a4981d2af28128201372b71420/pokemongo_bot/cell_workers/seen_fort_worker.py#L88) and just catches pokemon until there are no pokeballs left. Without pokeballs it will change to "farm" (https://github.com/OpenPoGo/OpenPoGoBot/blob/69a376bbf0cec29536a8d466ce4db11949ee7d89/pokemongo_bot/cell_workers/pokemon_catch_worker.py#L139) and the bot will only farm.

BetterBehavior

I think it should clean the inventory as set with item_filter on full bags. And it should farm only to get a few balls if there are none and start catching pokemons after that.

andythorne commented 8 years ago

As far as I can see, this will be addressed and fixed in #129 as the concept of a mode has been removed :)

andythorne commented 8 years ago

Closing as #129 is merged.