makes transfer_pokemon respect keep: false, fixes #341

tehp / OpenPoGoBot

A PokemonGo Python bot - NO LONGER MAINTAINED

MIT License

123 stars 53 forks source link

makes transfer_pokemon respect keep: false, fixes #341 #342

Closed torvitas closed 8 years ago

torvitas commented 8 years ago

Short Description:

see #341

Changes:

line 121 in transfer_pokemon to check the property keep instead of just looking if there is something in the array for the pokemon.

@OpenPoGo/maintainers

MaxLeiter commented 8 years ago

:+1:, but CI is failing

torvitas commented 8 years ago

I see, well I am not much of a python developer, but I guess I understand the problem.

meyer9 commented 8 years ago

:+1: fix travis

codecov-io commented 8 years ago

Current coverage is 51.26% (diff: 100%)

Merging #342 into master will not change coverage

@@             master       #342   diff @@
==========================================
  Files            34         34          
  Lines          1500       1500          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            769        769          
  Misses          731        731          
  Partials          0          0

Powered by Codecov. Last update eaa5bcb...226441a

torvitas commented 8 years ago

Although ci passes it looks like I broke the condition.

torvitas commented 8 years ago

Just fixed the condition, going to submit a new pull request.