search

tehp / OpenPoGoWeb

Web View for OpenPoGoBot
77 stars 58 forks source link

[Suggestion] Ability to rename bots instead of e-mail. #135

Open zenety opened 8 years ago

zenety commented 8 years ago

Would love to be able to change the name of my bots. So at least people who could access my web page won't be able to instantly see my e-mail.

jadbalout commented 8 years ago

I'm thinking of ways to do this, maybe changing the users array into a dictionary like so:

users: {"xd@gmail.com":"USERNAME_I_WANT",
"xd2@gmail.com":"Cool Bot"}

What do you think?

BobbyWibowo commented 8 years ago

@jadbalout To be fair, the config file is in a JS file which will be loaded alongside everything else, so it's still possible to peek the actual username.

jadbalout commented 8 years ago

@BobbyWibowo Fair enough. I guess that can't be done without removing the users and placing them in SQL Databases, which we do not intend to do.

BobbyWibowo commented 8 years ago

@jadbalout Yeah, but I personally still like a simple display name feature. I have done this on my personal repo. I roughly implemented it similar with your idea.

terbolous commented 8 years ago

Is there any other usage of this value, except picking the correct json files? If not then you have a couple of options, you could for instance symlink (or hardlink if you prefer) 'inventory-myusername@email.com.json' to 'inventory-CoolBot.json'.

Or ask for a similar feature in the bot (a config value for setting the json filenames)

BobbyWibowo commented 8 years ago

@eriweb As far as I'm aware, it's indeed only for getting the correct json files.